Martin Panter added the comment:

Looking over the code for communicate(), I think setting bufsize=0 should not 
cause a performance problem in the original use case. Communicate() either 
calls stdin.write() once, or bypasses the file object and calls os.write(). 
Only if stdin, stdout, etc were used before communicate(), then there could be 
a problem (and subtly different behaviour).

I left some suggestions on the code review.

----------
stage: needs patch -> patch review

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26372>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to