Berker Peksag added the comment: - now = time.time() - year, month, day, hh, mm, ss, x, y, z = time.localtime(now) - s = "%02d/%3s/%04d %02d:%02d:%02d" % ( - day, self.monthname[month], year, hh, mm, ss) + s = time.strftime("%d/%b/%Y %H:%M:%S", time.localtime())
This part of the patch is incorrect. time.strftime() will return non-English values for different locales. About deprecations of weekdayname and monthname attributes: I know that they are undocumented, but they are already being used in the wild. For example, see https://github.com/natemago/srv/blob/master/srv.py#L419 Since we don't have any public API for this use case, I'd be +1 to keep them for now. Here is an updated patch. ---------- Added file: http://bugs.python.org/file42153/issue747320_v2.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue747320> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com