Martin Panter added the comment: This patch looks okay to me. I left one review suggestion.
Focussing on test_sending_headers(), the ResourceWarning seems to be only shown since revision 46329eec5515 (Issue 26590). In simpler cases, the warning would be bypassed due to Issue 19829. But in this cases it seems there is a garbage cycle which may be involved in the new warning. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue26620> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
