Serhiy Storchaka added the comment: Nice.
> I discovered a flaw in the bytearray tests: most of them don’t actually test > bytearray objects! Good catch! > I adapted the tests from the deleted buffer_tests.py file to override the > relevant tests from string_tests.py, so that we continue to test bytearray > methods but with str a.k.a. bytes arguments. The patch LGTM. But may be instead of duplicating tests add fixfillchartype() (calling fixtype() by default)? If this don't complicate tests too much. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue26257> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com