New submission from Xiang Zhang: It seems some code in _PyObject_GenericSetAttrWithDict is not necessary. There is no need to check data descriptor again using PyDescr_IsData. And the second if (f != NULL) {} will never function.
---------- components: Interpreter Core files: _PyObject_GenericSetAttrWithDict.patch keywords: patch messages: 263297 nosy: xiang.zhang priority: normal severity: normal status: open title: Redundant code in _PyObject_GenericSetAttrWithDict versions: Python 3.6 Added file: http://bugs.python.org/file42450/_PyObject_GenericSetAttrWithDict.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue26745> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com