Martin Panter added the comment: The second patch looks reasonable (I left one minor grammar comment).
About getproxies_environment(), I meant that if you set no_proxy="", it may be ignored if NO_PROXY=. . . is also set. E.g. if you already have these set: http_proxy=http://proxy no_proxy=example.net NO_PROXY=example.net you should be able to override no_proxy="" to cancel bypassing for example.net. I agree the proxy_bypass() docstring looks wrong. If you want to write a patch to fix that, or to make the code more efficient or easier to understand, that would be good. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue26804> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
