Terry J. Reedy added the comment: Seems to be working correctly now, so I will review the code in detail. I will look into extracting a common get_theme_keys function and editing the long docstring currently attached to CurrentTheme. I want to look at paired functions in configdialog, such as def VarChanged_builtinTheme/Keys to see if there are any unnecessary differences.
The hardest thing is adding tests. Correct answers depend on the configuration vales, both default and user overrides. See #24737 for the latter. ---------- dependencies: +IDLE tests must be able to set user configuration values. stage: patch review -> test needed _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue27173> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com