Terry J. Reedy added the comment:

The issue with test_textview in 3.x is that tearDownModule deleted a module 
attribute, 'TV', that was not created in setUpModule.  For 2.7, 'TV' is a class 
attribute that is created in setUpClass and deleted in tearDownClass, so it 
does not have the same problem.  On the other hand, 'TV' is the original 
textView.TextViewer class, as modified with mocks in setUpClass.  The 
modifications are not reverted in tearDownClass.  This is the original code, 
later modified in 3.x.  This is safe both for re-runs and likely future tests, 
but this is not immediately obvious.  In any case, it violates the idea/rule 
that tests should not make permanent changes.  So I backported the local 
subclass of TextViewer used in 3.x.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27714>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to