Martin Panter added the comment: Rolf, just a note that I had to remove some trailing spaces on various continued lines in the Python code before it would let me push this.
Other tweaks I made: * Eliminate _read_iterable() and lambda * Rename line → chunk The Windows buildbots fail the test sending a pipe with urlopen(): http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Non-Debug%203.x/builds/1166/steps/test/logs/stdio ====================================================================== FAIL: test_http_body_pipe (test.test_urllib2.HandlerTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\buildarea\3.x.ware-win81-release\build\lib\test\test_urllib2.py", line 970, in test_http_body_pipe self.assertEqual(newreq.get_header('Content-length'), None) AssertionError: '0' != None I cannot figure out why exactly. My experiments with Wine suggest that tell() on a BufferedReader wrapping a pipe raises OSError, so I would expect _get_content_length() to return None, yet the test failure shows that Content-Length is set to zero. Is anyone able to investigate this on Windows? Will tell() and seek() reliably fail on a pipe or other unseekable file? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue12319> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
