Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Le vendredi 11 juillet 2008 à 22:18 +0000, Amaury Forgeot d'Arc a écrit : > I committed r64881, which invalidates your patch a bit :-|
Apparently you committed in trunk rather than py3k? Could you svnmerge into py3k as well? Then it should be quite easy to rework my patch around it. > BTW, I don't like your comment "Can't be bothered to check all those > PyFile_WriteString() calls". It's not my comment, it was already there. I agree it doesn't sound very meticulous. :-) > In general, it is not a good idea to execute python code with an > exception set, this leads to subtle problems, and some "XXX undetected > error" prints in debug mode. > Chaining several calls to PyDict_SetItem > for example is usually not a problem, but PyFile_WriteString does > execute python code in python3.0. Well, as said above, I just kept the original method of doing things... If you think of a simple solution to make things better (and a test case to validate it), I'm open to integrating it in the patch. _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3112> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
