Serhiy Storchaka added the comment:

There a problem with PySlice_GetIndicesEx() (see issue27867). Buffer length 
shouldn't be evaluated before PySlice_GetIndicesEx() since it can call user 
code that can change buffer length. This issue can't be solved without first 
solving issue27867.

get_buf() is called twice. First for getting the size, and later in 
buffer_item() or after PySlice_GetIndicesEx() for getting a pointer. I think it 
can be called once.

Ammar, please write a unittest for this issue. It should also cover bugs in the 
first two versions of the patch.

----------
dependencies: +various issues due to misuse of PySlice_GetIndicesEx

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29028>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to