Serhiy Storchaka added the comment:

The specification of ZIP files is not pretty clear, but the unzip utility first 
try to interpret offsets relatively to the start of the archive that can be 
different from the start of the file. Go's standard archive/zip package 
interprets offsets as absolute file positions and doesn't support concatenated 
ZIP files.

In any case there is a regression. Proposed patch partially reverts issue26293. 
Offsets in created ZIP file are now absolute when create with modes 'w' and 
'x'. But they are relative when create with mode 'a'. This should fix a 
regression in pex, but keep the case of issue26293.

I'm going to push the patch before tagging 3.5.3 rc1.

----------
keywords: +patch
nosy: +benjamin.peterson, larry, ned.deily
priority: normal -> release blocker
stage:  -> patch review
type:  -> behavior
versions: +Python 3.5, Python 3.6, Python 3.7
Added file: 
http://bugs.python.org/file46107/zipfile_write_absolute_offsets.patch

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29094>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to