Xavier de Gaye added the comment:
With input-readline.v3.patch, test_builtin runs with success on Android api 21.
With pep538_coerce_legacy_c_locale_v4.diff that implements PEP 538 in issue
28180, and with input-readline.v3.patch modified to have 'readline_encoding =
locale.getpreferredencoding()' even when 'is_android' is True, test_builtin
runs with success. This means that no specific Android handling would be needed
if PEP 538 were to be adopted.
The new input-readline.v4.patch is a slight improvement over the previous patch
and sets readline_encoding to 'UTF-8' on Android when test_builtin is run with
the environment variable LANG set to 'en_US.UTF-8' and in that case the test
exercises all the code paths including those with the readline module. This is
because locale.getdefaultlocale() returns ('en_US', 'UTF-8') on Android in that
case and because both getdefaultlocale() and readline scan the environment to
check for the locale. This new patch is only useful if tests on Android are
expected to be run also with one of the locale environment variables set to
UTF-8 (and PEP 538 is rejected).
I have left some comments on Rietveld.
----------
Added file: http://bugs.python.org/file46340/input-readline.v4.patch
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13886>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
