New submission from Steve Dower:

faulthandler adds a structured exception handler on Windows so we can dump a 
Python traceback before crashing. This should only be done for fatal 
exceptions, but is currently done for some non-fatal exceptions.

The current test is `flags & EXCEPTION_NONCONTINUABLE`, which is incorrect (as 
evidenced by the fact that the check is wrong in its current context and should 
be `!(flags & EXCEPTION_NONCONTINUABLE)`).

Instead, `code & 0x80000000` determines whether the exception is an error. If 
not, we should skip logging any info.

----------
assignee: steve.dower
components: Windows
messages: 295054
nosy: haypo, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
stage: patch review
status: open
title: faulthandler does not correctly filter fatal exceptions on Windows
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30557>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to