Berker Peksag added the comment: I don't think most of the changes improve readability of json.tool. Everyone has their own preferences and it's usually not enough to justify code churn.
Also, we don't need to add comments when the code itself is pretty descriptive: # Output JSON with options.outfile as outfile: json.dump(obj, outfile, sort_keys=options.sort_keys, indent=4) outfile.write('\n') IMO, the only acceptable change is the correct use of 'default' parameter for 'infile' and 'outfile'. ---------- nosy: +berker.peksag stage: -> patch review type: -> enhancement _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue30971> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com