Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:
The "goto error" is not necessary here. Nothing has been allocated at
this point, and "return -1" is enough.
Index: Modules/_fileio.c
===================================================================
--- Modules/_fileio.c (revision 65957)
+++ Modules/_fileio.c (working copy)
@@ -175,7 +175,7 @@
kwlist,
Py_FileSystemDefaultEncoding,
&name, &mode, &closefd))
- goto error;
+ return -1;
}
}
----------
keywords: +needs review
nosy: +amaury.forgeotdarc
_______________________________________
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3662>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
