Terry J. Reedy added the comment:

I did not refresh this before writing the above.  It still applies, including 
deleting the commented out code once tests pass.  See review.

Whoops: I forgot that using make_default means that we can (and should) delete 
the replaced var_changed defs.  I added the one for space_num back because I 
mistakenly thought it was needed to make the test pass.

I will open a new issue to add a comment documenting the new TabPage(Frame) 
class design.  The new rules will include using default var_changes when 
possible. Patch will include adjusting FontTab to follow the new rules.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31050>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to