Serhiy Storchaka added the comment:

Oren already fixed several similar problems and he is aware of difference 
between a crash and an exception.

The problem is Windows specific. The current code uses Unicode C API with the 
result of calling the replace method. This can cause a segfault (or may be an 
assertion failure in debug build).

The proposed solution LGTM. It undermines duck-typing, but I think this doesn't 
break any existing code. The duck-typing was not intentional and is 
Windows-only.

----------
components: +Extension Modules -Interpreter Core
nosy: +serhiy.storchaka
stage:  -> patch review
versions: +Python 3.6

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31291>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to