STINNER Victor <victor.stin...@gmail.com> added the comment:

Copy of my comment on the PR: "So, I tried to remove the backward compatibility 
layer: I modified stat_result[ST_MTIME] to return float rather than int. 
Problem: it broke test_logging, the code deciding if a log file should be 
rotated or not.

While I'm not strongly opposed to modify stat_result[ST_MTIME], I prefer to do 
it in a separated PR. Moreover, we need maybe to emit a DeprecationWarning, or 
at least deprecate the feature in the doc, before changing the type, no?"

Serhiy's answer: "I agree, it should be done in a separate issue. It needs a 
special discussion. And maybe this can't be changed."

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31827>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to