Nick Coghlan <ncogh...@gmail.com> added the comment: Explicitly noting some API design decisions from the review of https://github.com/python/cpython/pull/4790:
1. AsyncExitStack will define __aenter__ and __aexit__ but *not* __enter__ and __exit. This makes it unambiguous which form of with statement you need to be using for a given stack. 2. AsyncExitStack will use the same methods to add synchronous context managers as ExitStack does 3. The only common method with clearly distinct external behaviour will be stack.close(), which will be a coroutine in the AsyncExitStack case (the other common methods will all still be synchronous in AsyncExitStack) 4. AsyncExitStack will gain 3 new methods for working with async context managers: - enter_async_context(cm): coroutine to enter an async context manager and adds its __aexit__ to the context stack if __aenter__ succeeds - push_async_exit(cm_or_exit): push an exit callback directly onto the stack. The argument must either be an object implementing __aexit__, or else a callback with the same signature as __aexit__ (use stack.push() to register a synchronous CM or exit callback) - push_async_callback(callback): push the given callback onto the stack. The callback should return an awaitable (use stack.callback() to register synchronous callbacks) ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue29302> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
