Stefan Krah <ste...@bytereef.org> added the comment: Tests -----
I ran some of my own tests (not even close to all), they seem fine. However, I could not find any tests for the added feature (safe use with async) though. We would be adding a new feature without tests. Performance ----------- I'm getting a large slowdown: ./python Modules/_decimal/tests/bench.py bench.py ________ patched: [0.199, 0.206, 0.198, 0.199, 0.197, 0.202, 0.198, 0.201, 0.213, 0.199] status-quo: [0.187, 0.184, 0.185, 0.183, 0.184, 0.188, 0.184, 0.183, 0.183, 0.185] slowdown: > 10% xwith.py -------- patched: [0.535, 0.541, 0.523] status-quo: [0.412, 0.393, 0.375] slowdown: > 30% Given the performance issues I'm -1 for adding the feature at this point. ---------- Added file: https://bugs.python.org/file47410/xwith.py _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32630> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
