STINNER Victor <vstin...@redhat.com> added the comment:
+ def tearDown(self): + self.executor.shutdown(wait=True) + dt = time.time() - self.t1 + if test.support.verbose: + print("%.2fs" % dt, end=' ') + self.assertLess(dt, 60, "synchronization issue: test lasted too long") This code has been added by: commit aebac0b55a1e3addb93ec7992046a4f9561b4175 Author: Antoine Pitrou <solip...@pitrou.net> Date: Thu Mar 24 15:47:39 2011 +0100 Add tests for the atexit hook in concurrent.futures (part of #11635) What is the purpose of having an hardcoded maximum test execution duration? If a test takes 2 seconds instead of 1, it means that the test found a design issue in concurrent.futures? Or it would mean that the test has a bug? We have many buildbots which are super slow, so I proposed to increase the maximum duration to 5 minutes instead of 1 minute to quickly repair buildbots. But with 5 minutes, I'm not sure that the check is still useful. @Antoine: do you recall the rationale for this check? ---------- nosy: +pitrou _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue33716> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com