Alexandre Vassalotti <[EMAIL PROTECTED]> added the comment:
The patch looks good to me.
You may want to fix the refleak in the PyList_Append() calls (I counted
4) too:
if (PyList_Append(chunks, chunk)) {
goto bail;
}
should be:
if (PyList_Append(chunks, chunk)) {
Py_DECREF(chunk);
goto bail;
}
Also, line 384 and 548:
Py_DECREF(chunks);
chunks = NULL;
should changed to
Py_CLEAR(chunks);
----------
nosy: +alexandre.vassalotti
_______________________________________
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3623>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
