Guido van Rossum <gu...@python.org> added the comment:
I disagree. Other than subclasses of thread executor, what are you going to pass in? A mock? On Wed, Jul 11, 2018 at 7:34 AM STINNER Victor <rep...@bugs.python.org> wrote: > > STINNER Victor <vstin...@redhat.com> added the comment: > > > I think we'll only allow instances of c.f.ThreadPoolExecutor (and its > subclasses) to be passed to set_default_executor. That's a more robust > check than just guarding against ProcessPoolExecutor. > > I suggest to only reject ProcessPoolExecutor, instead of having a very > specific test on ThreadPoolExecutor which might fail with funky but valid > thread executor. > > ---------- > nosy: +vstinner > > _______________________________________ > Python tracker <rep...@bugs.python.org> > <https://bugs.python.org/issue34075> > _______________________________________ > -- --Guido (mobile) ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue34075> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
