Antoine Pitrou <[EMAIL PROTECTED]> added the comment: I haven't tried the patch as is but I can spot two problems: - you should use PyList_CheckExact instead of PyList_Check, because a list subclass could override __getitem__ - when keyfunc is not NULL, you can't assume that the list size will stay constant; indeed, calling keyfunc may mutate the list (try something like `max(l, key=l.pop)`)
I've got no opinion on whether the speedup is worth the added complexity. Perhaps a way of simplifying the patch would be to enable the special path only when keyfunc==NULL. Others may comment. ---------- nosy: +pitrou, rhettinger versions: +Python 2.7, Python 3.1 -Python 2.5.3 _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4174> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
