STINNER Victor <vstin...@redhat.com> added the comment:
I don't think that the attached patch is correct. See attached install.diff: difference without/with 00178-dont-duplicate-flags-in-sysconfig.patch on Python installed in /usr/bin/python3. Example of bug: 'TESTRUNNER': 'LD_LIBRARY_PATH=/builddir/build/BUILD/Python-3.7.1/build/optimized ' - './python ' - '/builddir/build/BUILD/Python-3.7.1/Tools/scripts/run_tests.py', + './python /Tools/scripts/run_tests.py', The /Tools directory doesn't exist :-/ > I think that this is not the correct behaviour, but not sure, maybe I'm doing > something wrong. Technically, it's perfectly fine to pass the same flag multiple times. It's common to pass -O0 -Og to gcc for example: gcc uses the last -O option value (which overrides the previous ones). -- This patch is used in the python3 package of Fedora: https://src.fedoraproject.org/rpms/python3/blob/master/f/00178-dont-duplicate-flags-in-sysconfig.patch Patch added by: commit 58f477b403222ea6c13d5d7358551b606cddc0f8 Author: Bohuslav Kabrda <bkab...@redhat.com> Date: Wed Apr 10 14:30:09 2013 +0200 Updated to Python 3.3.1. - Refreshed patches: 55 (systemtap), 111 (no static lib), 146 (hashlib fips), 153 (fix test_gdb noise), 157 (uid, gid overflow - fixed upstream, just keeping few more downstream tests) - Removed patches: 3 (audiotest.au made it to upstream tarball) - Removed workaround for http://bugs.python.org/issue14774, discussed in http://bugs.python.org/issue15298 and fixed in revision 24d52d3060e8. https://src.fedoraproject.org/rpms/python3/c/58f477b403222ea6c13d5d7358551b606cddc0f8?branch=master ---------- nosy: +vstinner Added file: https://bugs.python.org/file48003/install.diff _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue17679> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
