Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: The new patch looks fine to me. It applies and compiles without warnings and the changes are now reflected in the docs. I guess someone would need to write a NEWS entry because it is a public API change, but otherwise I would say it should be applied.
"[U]nless 'C' has adopted overloading while I wasn't looking ... it's hard to imagine what kind of problems you could introduce in `C' code by changing char* to char const* that wouldn't be caught at compile-time." (Dave Abrahams in C++-sig) http://mail.python.org/pipermail/cplusplus-sig/2005-December/009562.html On Thu, Nov 13, 2008 at 2:24 PM, Sebastian Ramacher <[EMAIL PROTECTED]> wrote: .. >> * Same for PySys_SetArgv(int, char **) > > That one is non-trivial and requires some rewriting of PySys_SetArgv. > And I didn't have the time to look into it any further. > I agree and I only tossed this one in to check if you are aware of the char ** issues. I believe it was agreed at some point that changing char ** to const char ** is not a good idea (see revision 42596 reverting such change), but I could not find a clear explanation of the associated problems. In any case, +1 from me in favor of applying this patch and I will try to add Jeremy Hylton to the "nosy" list since he is the developer who made similar API changes in r41638 . _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1699259> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com