Emmanuel Arias <emmanuelaria...@gmail.com> added the comment:

Hi Berker, 

Thanks for you response. 

I agree when you say that patch.dict is a simply operation, but I think that 
this test can be necessary, if for some reason the implementation of patch.dict 
(or its parts) decide change. 

> I think the relationship between dict and OrderedDict (including any other 
> dict subclasses and dict-like objects) and anything related to insertion 
> order should be tested either in test_dict or in test_ordered_dict.

I am not sure if this has to be tested on test_dict or test_oredered_dict, 
because we are not testing specifically dict-like objects.

This test, can be written on test_patch_dict and not create a new 
`test_patch_dict_with_orderdict`.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue24928>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to