Rémi Lapeyre <remi.lape...@henki.fr> added the comment:

> Btw: The name "read_dict" [1] as well as its docstring say exactly the 
> opposite of what it does. It acts as a "save_dict". Maybe that can be fixed 
> on the go ...


The name `read_dict` is correct, it reads from the dict given as parameter and 
changing the name would break existing code.

I opened a new PR with the change to convert keys to strings in __getitem__, I 
did not wrap `key = str(key)` in a try-except as it's not done in read_dict(). 
This way both __getitem__ and read_dict() will fail the same way.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue35954>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to