Roumen Petrov <[EMAIL PROTECTED]> added the comment: Akira Kitada wrote: > Akira Kitada <[EMAIL PROTECTED]> added the comment: > > Roumen, > Thanks for the feedback! > > This patch disables __attribute__ when PY_FORMAT_SIZE_T isn't defined, > not always.
I would like to clarify. After patch if PY_FORMAT_SIZE_T isn't defined then __attribute__(XXX) will be ignored always irrespective of content, i.e. XXX. > About the name of the macro, I think you are right. > Py_GCC_FORMAT_ATTRIBUTE would be much better name if it is not used for > other uses. (I'm not sure) > I'll look into the code more and if it seems being safe to rename it, > I'll update the patch and resubmit it. The current python code use Py_GCC_ATTRIBUTE only for 'format(printf(...)) ' attribute. The patch will prevent python to use this macro in future for other attributer. Also I'm not sure that I would like warning to be hidden. As example I know that GCC(mingw) 3.5.x don't support %z and I prefer to see those warnings instead to hide them. Roumen _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4370> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
