Stéphane Wirtel <steph...@wirtel.be> added the comment: your PR seems to be fine.
but I continue to get two refleaks with valgrind but don't worry, @vstinner is working on these refleaks. ==5440== 64 bytes in 1 blocks are possibly lost in loss record 1 of 2 ==5440== at 0x483880B: malloc (vg_replace_malloc.c:309) ==5440== by 0x46BFAB: _PyMem_RawMalloc (obmalloc.c:99) ==5440== by 0x46BEA3: _PyMem_DebugRawAlloc (obmalloc.c:2020) ==5440== by 0x46BF33: _PyMem_DebugRawMalloc (obmalloc.c:2049) ==5440== by 0x46D304: PyMem_RawMalloc (obmalloc.c:527) ==5440== by 0x52C1EF: PyThread_allocate_lock (thread_pthread.h:330) ==5440== by 0x5154F0: _PyRuntimeState_Init_impl (pystate.c:52) ==5440== by 0x515A76: _PyRuntimeState_Init (pystate.c:77) ==5440== by 0x514114: _PyRuntime_Initialize (pylifecycle.c:88) ==5440== by 0x4236FE: pymain_init (main.c:339) ==5440== by 0x423980: pymain_main (main.c:889) ==5440== by 0x423A6A: _Py_UnixMain (main.c:940) ==5440== ==5440== 64 bytes in 1 blocks are possibly lost in loss record 2 of 2 ==5440== at 0x483880B: malloc (vg_replace_malloc.c:309) ==5440== by 0x46BFAB: _PyMem_RawMalloc (obmalloc.c:99) ==5440== by 0x46BEA3: _PyMem_DebugRawAlloc (obmalloc.c:2020) ==5440== by 0x46BF33: _PyMem_DebugRawMalloc (obmalloc.c:2049) ==5440== by 0x46D304: PyMem_RawMalloc (obmalloc.c:527) ==5440== by 0x52C1EF: PyThread_allocate_lock (thread_pthread.h:330) ==5440== by 0x515506: _PyRuntimeState_Init_impl (pystate.c:58) ==5440== by 0x515A76: _PyRuntimeState_Init (pystate.c:77) ==5440== by 0x514114: _PyRuntime_Initialize (pylifecycle.c:88) ==5440== by 0x4236FE: pymain_init (main.c:339) ==5440== by 0x423980: pymain_main (main.c:889) ==5440== by 0x423A6A: _Py_UnixMain (main.c:940) ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue36356> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com