STINNER Victor <vstin...@redhat.com> added the comment:

> It is better to not use assert(foo && bar). Use instead two separate asserts: 
> assrte(foo) and assert(bar).

Hum, I looked at my PR and I'm not sure that I added such new assertion.

Note: "assert" on calling assert(_PyDict_CheckConsistency(mp)) is only used to 
remove the call in release build, but the function always return 1. The 
function does uses assert() or _PyObject_ASSERT() internally with a different 
line number and the exact failing expression.

Do you want me to enhance existing _PyDict_CheckConsistency() assertions in the 
same PR?

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue36389>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to