Matthias Bussonnier <bussonniermatth...@gmail.com> added the comment:
> There would still be a breakage for that if someone was defining py36+ > `visit_Constant` (which would clobber the `ast.NodeVisitor.visit_Constant` if > we were to add it) Ok, it would still break in some cases, but that would still be a net improvement for codebase that do not override visit_Constant; right ? We could also push the patch further if we really want and call explicitly NodeVisitor.visit_Constant before the overridden method in NodeVisitor.visit. Not advocating for the second part, but minimal breakage and code repetition in libraries when we can. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue36917> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
