Jeffrey Yasskin <[EMAIL PROTECTED]> added the comment: I think your patch leaks a reference to 'x'. Move the Py_DECREF(x) to before "if (err < 0)"?
And then really nitpicky: your test has 3 blank lines after it, and should have 2. Otherwise looks great. Thanks for picking this up! ---------- keywords: -needs review resolution: -> accepted stage: patch review -> commit review _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4589> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
