Antoine Pitrou <[email protected]> added the comment:
I'm not in a position to comment on the encoding algorithm itself but I
have a couple of comments:
* I get the following compilation warning:
Objects/unicodeobject.c: In function ‘PyUnicode_DecodeUTF7Stateful’:
Objects/unicodeobject.c:1531: attention : ‘shiftOutStart’ may be used
uninitialized in this function
* shouldn't there be an additional test for the '/' behaviour (unless it
is already there and I have overlooked it)?
* your patch fails on another test:
Traceback (most recent call last):
File "Lib/test/test_unicode.py", line 538, in test_codecs_utf7
self.assertRaises(UnicodeDecodeError, '+\xc1'.decode, 'utf-7')
AssertionError: UnicodeDecodeError not raised
----------
keywords: +needs review, patch
priority: -> critical
stage: -> patch review
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue4426>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
