Shai <shaia1112...@gmail.com> added the comment:

>From the docs (https://docs.python.org/3/library/os.html#os.scandir.close):

"This is called automatically when the iterator is exhausted or garbage 
collected, or when an error happens during iterating. However it is advisable 
to call it explicitly or use the with statement.".

The iterator is indeed closed properly, but the docs state that it's still 
advisable to close it explicitly, which is why I wrapped it in a with statement.

However, the more important change is that the iterator is no longer converted 
into a list, which should reduce the iterations from 2N to N, when N is the 
number of entries in the directory (one N when converting to list and another 
one when iterating it). This should enhance the performance of the functions 
that use scandir.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue37935>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to