Kyle Stanley <aeros...@gmail.com> added the comment:
> One more resource warning about unclosed resource being garbage collected. As
> per the other tests I think transport and protocol need to be closed as per
> below patch but someone can verify if it's the right approach.
Ah, good catch. It's not needed when the ValueError occurs because it prevents
the transport and protocol from being created in the first place, but I forgot
that it would still be needed for the DeprecationWarning test. In addition to
your changes, I'll also add a self.assertEqual('CLOSED', protocol.state). This
is done in most of the other tests and it doesn't hurt to make sure the
protocol properly closed.
I'll add your fix to the PR and add you to the "Co-authored-by" for that
commit, thanks.
----------
_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue37228>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
