Ulrich Eckhardt <eckha...@satorlaser.com> added the comment: I have a patch here which passes the proposed change to the tests in trunk. A few notes up front though, since the patch isn't good yet:
1. The handling of the error in internal_close() isn't really good. What I'm also not sure about is whether it is correct to set the error there, the old code sometimes did set an error as reaction to internal_close() failing and sometimes not. 2. There is one place in dircheck() where I think that the error should be ignored, but I'm not sure about that. 3. This patch fixes another issue, and that is that internal_close() would call close() even if 'closefd' was not set. This e.g. happens when __init__ is called explicitly. This case is missing a test though. 4. I wonder if internal_close() should reset only the 'fd' field or if it should also reset 'readable', 'writable', 'seekable', too, i.e. apart from 'weakreflist' do the same as fileio_new() does. Added file: http://bugs.python.org/file12595/python-2.7-fileio-close-fix.0.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue4841> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
