Serhiy Storchaka <storchaka+cpyt...@gmail.com> added the comment:

Sorry Zackery, I did not know about this issue so I wrote different PR to fix 
this problem. And only after writing it I have found this issue.

There are several differences between your PR and PR 18863.

* SystemError is raised instead of ValueError because this is incorrect use of 
the C API.
* The error message mentions also base 10.
* The test is written mostly in Python.

For these reasons I prefer my PR.

Please let me know if you need a review for other PRs.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue38643>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to