New submission from Chris Martinez <sydef...@hotmail.com>:

CPython provides a NuGet package as a mechanism to support non-installed Python 
distributions. The package includes MSBuild support to integrate with its build 
process.

The expressions on lines 32 and 33 in the file:

https://github.com/python/cpython/blob/master/PC/layout/support/props.py

are both missing closing parentheses, which results in literal text instead of 
the resolve file paths. This appears to be introduced in version 3.7.2 of the 
package onward, including the current pre-release 3.9.0-a5.

In addition, several build conditions use the form " $(Property) == 'value' ", 
but should instead use " '$(Property)' == 'value' ". By not surrounding the 
property value with '', the condition may resolve as "  == '' ", which is an 
invalid expression and will cause a build failure. This doesn't appear to have 
caused an issue yet, but it easily could.

If there is no further discussion or objection, I can submit a PR with the 
required fixes.

----------
components: Build, Demos and Tools, Distutils, Installation, Windows
messages: 365610
nosy: dstufft, eric.araujo, paul.moore, steve.dower, sydefekt, tim.golden, 
zach.ware
priority: normal
severity: normal
status: open
title: MSBuild Extensions in CPython NuGet Package has Bad Expression
type: compile error
versions: Python 3.7, Python 3.8, Python 3.9

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue40158>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to