Benjamin Peterson <benja...@python.org> added the comment: I don't like the change of API to PyTokenizer_FromString. I would prefer another function like PyTokenizer_IgnoreCodingCookie() blows up when parsing has already started.
The (char *) cast in PyTokenizer_FromString is unneeded. You need to indent the "else" clause after you test for ignore_cookie. I'd like to see a test that shows that byte strings still have their cookies examined. ---------- nosy: +benjamin.peterson _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue4626> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com