Marc-Andre Lemburg <m...@egenix.com> added the comment: On 2009-01-26 17:56, STINNER Victor wrote: > STINNER Victor <victor.stin...@haypocalc.com> added the comment: > > @marketdickinson, @lemburg: ping! I updated the patch, does it look > better?
Yes, but there are a few things that still need fixing: * SIZEOF_WCHAR_T is not defined for Windows builds, so needs to be added to PC/pyconfig.h (OTOH wchar_t is 2 bytes on Windows) * USE_WCHAR_SURROGATE should be #defined just before the function and #undef'ed right after it; I'd also use a more accurate name * please use pre-processor indents, e.g. #ifdef ... # define ... #endif I'd write #if (Py_UNICODE_SIZE == 2) && defined((SIZEOF_WCHAR_T) && (SIZEOF_WCHAR_T > 2) # define CONVERT_WCHAR_TO_SURROGATES #endif ... #undef CONVERT_WCHAR_TO_SURROGATES Thanks. _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue4474> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
