Brett Cannon <br...@python.org> added the comment: On Mon, Feb 2, 2009 at 13:50, Brett Cannon <br...@python.org> wrote: > On Mon, Feb 2, 2009 at 12:42, Martin von Gagern <rep...@bugs.python.org> > wrote: >> >> Martin von Gagern <martin.vgag...@gmx.net> added the comment: >> >> Next iteration. With magic number, and now also closing the file again. >> I changed from unpack and number comparison to pack and string >> comparison, makes things a bit easier, as there is only one comparison, >> and as underflow of the packed data isn't an issue any more. >> >> Would you prefer the use of private marshal functions, as bootstrap >> does, over the struct packing as I do here? >> > > No since importlib only does it that way for bootstrapping > considerations (might end up at the implementation of import itself so > it has special requirements). > >> Looking forward to your review. > > I have not looked, Martin, but are proper tests in place already in > the standard library? If not I would appreciate tests. >
Although, now that I said that, I have had testing issues myself when it comes to mtime on bytecode as Python tends to execute faster than the granularity the file system supports. _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue5128> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
