Jason R. Coombs <jar...@jaraco.com> added the comment:

I started work on a test in 
https://github.com/jaraco/cpython/tree/bugfix/bpo-38780-test, but (a) the test 
was failing to exhibit the expected failures, and (b) I realized that the fix 
isn't having the intended effect either, because for unix sockets, [self.socket 
is unconditionally 
set](https://github.com/python/cpython/blob/dfdca85dfa64e72df385b3a486f85b773fc0f135/Lib/logging/handlers.py#L872),
 overriding any NullSocket or None value.

The SysLogHandler code will need to be reorganized if self.socket is intended 
to model two modes (broken and initialized).

I'm not sure when I'll get another chance to take a look at this, but I'll not 
be able to wrap it up today, so I'm going to unassign it for now.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue38780>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to