Erlend Egeberg Aasland <erlend.aasl...@innova.no> added the comment:
> There are three calls of pysqlite_statement_reset() in > _pysqlite_query_execute() Yes, but only two before the cache is queried. > So additional call of pysqlite_statement_reset() does not harm. That's true, but removing redundant code makes it easier to read and maintain, IMO. > On other hand removing it can introduce race condition. How? > Maybe the code could be rewritten in more explicit way and call > pysqlite_statement_reset() only when it is necessary Most of _pysqlite_query_execute() could be rewritten in order to make the code clearer. An alternative is to clean it up part by part. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue43350> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
