Batuhan Taskaya <isidenti...@gmail.com> added the comment:
After playing with it for a couple hours and without much success of creating a test environment (only using buildbots), I decided not to introduce hard limits. Even though they make the original tests to pass, they don't solve the problem overall and also more important part is that the 'hard limits' might cause regressions for people who do compile(<AST>) calls. For normal windows builds (as @kj noted) something might work in the current revision and we might just break it with introducing hard limits. Since the trees are tend to get really branchy, I don't think it is a good idea. I'm open to any proposals/plans Extra: In the worst case that we can't come up with something (the AST converter functions are really long 2000+ LoC C functions so it is possible that there might be stuff that eats a lot of space on the stack), we can either a) revert => not a good option, this is not a regression on the python itself. It is a fix for other os's and windows release builds b) always skip the test on windows => we can do that but it might be counterintuitive for the future c) use a really low recursion limit for the test_recursion_* for windows => I'm open to fallback to this if nothing comes up. we might need to revert this though as is it is not a regression. It used to crash with the same exact error, just outside of the test suite, and now since it works for linux/macos/others + windows for release builds I wonder whether can just skip the test on windows and keep it as is in the worst scenario). ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue11105> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
