Mattias Engdegård <yor...@users.sourceforge.net> added the comment:
The patch looks all right in general. I would use something like if "poll" in dir(select) instead of catching AttributeError which risks hiding bugs in _communicate_with_poll(). PEP8 probably wants spaces around the bitwise-or operator. Some systems cannot use TTYs in poll(2) but this should not be a problem here - there is no point in using .communicate() with stdin/ stdout/stderr set to anything but PIPE, right? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue3392> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
