Géry <gery.o...@gmail.com> added the comment:
Thanks Hugo for opening this issue and Éric for inviting me.
As you guys pointed out, function test in module http.server expects a real
handler class argument (SimpleHTTPRequestHandler or CGIHTTPRequestHandler), not
a partial object partial(SimpleHTTPRequestHandler, directory=args.directory) or
partial(CGIHTTPRequestHandler, directory=args.directory), so that the
assignment of protocol_version class attribute in test is not ignored.
The partial object in the if __name__ == '__main__' branch of module
http.server was introduced in the first place to pass the directory argument to
the handler class’s __init__ method called in method BaseServer.finish_request:
def finish_request(self, request, client_address):
"""Finish one request by instantiating RequestHandlerClass."""
self.RequestHandlerClass(request, client_address, self)
But finish_request is a factory method of BaseServer (the abstract creator) so
it is DESIGNED to be overridden in subclasses to customize the instantiation of
the handler class BaseRequestHandler (the abstract product). So the proper way
to instantiate SimpleHTTPRequestHandler and CGIHTTPRequestHandler with the
directory argument is to override BaseServer.finish_request.
That is what I have just did by updating my PR here:
https://github.com/python/cpython/pull/30701/commits/fc7f95f9d270a8a83cb2fd6d51eb0f904b85e0d9
It fixes both #46285 and #46436.
----------
_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue46285>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
