Nick Barnes <nick.bar...@pobox.com> added the comment: This was my first contribution to Python. I don't know what the rules are on changing the arguments of an internal function such as PyUnicode_EncodeUTF7(). Since I was rewriting the whole function anyway, I tried to give it arguments which made more sense with respect to the defining RFC. If you want us to revert to the original meanings of these arguments (so the third argument means "use base-64 encoding for characters in set O", and not "use direct encoding for characters in set O"), please can we have better names for them?
The name "encodeSetO" was meaningless: the function encodes *all* the characters in the string. What the argument specifies is whether the "set O" characters are self-encoded or base-64 encoded. So maybe it should be called "base64SetO". Ditto for the "encodeWhiteSpace" name. Here's a trunk patch with the meaning of those parameters reverted, and better names. ---------- Added file: http://bugs.python.org/file13872/python-unicode-trunk-patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue4426> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
