Tal Einat <talei...@users.sourceforge.net> added the comment: The whole point of this patch is to make the EditorWindow's Text widget the default master/parent for its dialogs!
IMO this makes sense, since this is a reasonable and intuitive default for such methods of the EditorWindow object. I understand the "explicit is better than implicit" argument, but that doesn't mean that having a reasonable default value is always wrong. In this case having a default value both simplifies the code considerably and makes sense, so IMO it is justified. Also, please note that the patch actually reduces the size of EditorWindow.py (both character and line counts) and cleans up the code in many places. Yes, the definition of the relevant methods is not trivial, but it is in just one area of the code. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue2053> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com